Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw field names in property structs #2273

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

WorldSEnder
Copy link
Member

Description

Allows the fields of #[derive(Properties)] structs to be raw names, r#raw_ident. The main tool is to use quote::format_ident!() instead of Ident::new(format!()) which correctly passes on the raw nature of identifiers instead of rejecting them.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@WorldSEnder WorldSEnder changed the title Raw property names in property structs Raw field names in property structs Dec 15, 2021
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@voidpumpkin voidpumpkin added the A-yew-macro Area: The yew-macro crate label Dec 15, 2021
@siku2 siku2 merged commit c2d39d7 into yewstack:master Dec 15, 2021
@WorldSEnder WorldSEnder deleted the raw-property-names branch December 15, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-macro Area: The yew-macro crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants